Re: [PATCH v4 2/3] qemu: extract common PCI handling functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Ján Tomko wrote:

> On 05/11/2014 08:48 AM, Roman Bogorodskiy wrote:
> > Move sharable PCI handling functions to domain_addr.[ch], and
> > change theirs prefix from 'qemu' to 'vir':
> > 
> >  - virDomainPCIAddressAsString;
> >  - virDomainPCIAddressBusSetModel;
> >  - virDomainPCIAddressEnsureAddr;
> >  - virDomainPCIAddressFlagsCompatible;
> >  - virDomainPCIAddressGetNextSlot;
> >  - virDomainPCIAddressReleaseSlot;
> >  - virDomainPCIAddressReserveAddr;
> >  - virDomainPCIAddressReserveNextSlot;
> >  - virDomainPCIAddressReserveSlot;
> >  - virDomainPCIAddressSetFree;
> >  - virDomainPCIAddressSetGrow;
> >  - virDomainPCIAddressSlotInUse;
> >  - virDomainPCIAddressValidate;
> > 
> > The only change here is function names, the implementation itself
> > stays untouched.
> > 
> > Extract common allocation code from DomainPCIAddressSetCreate
> > into virDomainPCIAddressSetAlloc.
> 
> Unrelated whitespace change.
> 
> ACK with the ATTRIBUTE_NONNULL removed for model.

Pushed 1/3 and 2/3 with the fixes applied; thanks.

Roman Bogorodskiy

Attachment: pgpt5pOjfB8fB.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]