Re: [PATCH v7 1/6] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/02/2014 03:48 AM, Daniel P. Berrange wrote:
> On Thu, May 01, 2014 at 08:05:48PM -0400, Tomoki Sekiyama wrote:
>> These will freeze and thaw filesystems within guest specified by
>> @mountpoints parameters. The parameters can be NULL and 0, then the all

s/the all/all/

>> mounted filesystems are frozen or thawed. @flags parameter, which are
>> currently not used, is for future extensions.
>>
>> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxx>
>> ---
>>  include/libvirt/libvirt.h.in |   10 +++++
>>  src/driver.h                 |   14 ++++++
>>  src/libvirt.c                |   93 ++++++++++++++++++++++++++++++++++++++++++
>>  src/libvirt_public.syms      |    6 +++
>>  4 files changed, 123 insertions(+)

> 
> + * may be required depending on hypervisor used). If @mountpoints is NULL or
> + * @nmountpoints is 0, every mounted filesystem on the guest is frozen.

s/or/and/ (since the code requires both or neither to be 0)

> + * support mountpoints argument), @mountpoints may be ignored.

s/be ignored/need to be NULL/

> 
> ACK

Pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]