On 04/27/2014 06:15 PM, Julio Faracco wrote:
> In "src/conf/" there are many enumeration (enum) structures like "src/util" directory, for example. Sometimes, it's better using a typedef for variable types, function types and other usages. Other enumeration and folders will be changed to typedef's in the future.
> Most of the files changed in this commit included Network Filter (nwfilter.*) enum structures.
Long lines again.
>
> Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx>
> ---
> src/conf/node_device_conf.h | 24 ++++++++++++------------
> src/conf/nwfilter_params.c | 2 +-
> src/conf/nwfilter_params.h | 14 +++++++-------
> 3 files changed, 20 insertions(+), 20 deletions(-)
>
Fails to compile:
CC
nwfilter/libvirt_driver_nwfilter_impl_la-nwfilter_gentech_driver.lo
node_device/node_device_udev.c:1172:24: error: 'enum virNodeDevCapType'
declared inside parameter list [-Werror]
enum virNodeDevCapType *type)
^
node_device/node_device_udev.c:1172:24: error: its scope is only this
definition or declaration, which is probably not what you want [-Werror]
node_device/node_device_udev.c: In function 'udevGetDeviceType':
node_device/node_device_udev.c:1179:5: error: dereferencing pointer to
incomplete type
*type = 0;
^
Can you please rebase this patch, then fix and resubmit it? Ask if you
need help figuring out how to use 'git rebase -i' (the IRC channel might
get you a bit more of a realtime response, if you need it).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list