Re: [PATCH 1/2] virsh: Replace list element to defined variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/28/2014 08:10 PM, Li Yang wrote:
> Signed-off-by: Li Yang <liyang.fnst@xxxxxxxxxxxxxx>
> ---
>  tools/virsh-secret.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c
> index 47974fe..e996c72 100644
> --- a/tools/virsh-secret.c
> +++ b/tools/virsh-secret.c
> @@ -558,7 +558,7 @@ cmdSecretList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED)

Additional context:

    for (i = 0; i < list->nsecrets; i++) {
        virSecretPtr sec = list->secrets[i];


>          const char *usageStr = virSecretUsageTypeTypeToString(usageType);
>          char uuid[VIR_UUID_STRING_BUFLEN];
>  
> -        if (virSecretGetUUIDString(list->secrets[i], uuid) < 0) {
> +        if (virSecretGetUUIDString(sec, uuid) < 0) {

No semantic difference.  But doesn't hurt, so ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]