On 04/29/2014 05:12 AM, Martin Kletzander wrote: > On Mon, Apr 28, 2014 at 09:53:55PM -0600, Eric Blake wrote: >> All callers of virStorageFileGetMetadataFromBuf were first calling >> virStorageFileProbeFormatFromBuf, to learn what format to pass in. >> But this function is already wired to do the exact same probe if >> the incoming format is VIR_STORAGE_FILE_AUTO, so it's simpler to >> just refactor the probing into the central function. >> >> src/libvirt_private.syms | 1 - >> src/storage/storage_backend_fs.c | 8 -------- >> src/storage/storage_backend_gluster.c | 5 ----- >> src/util/virstoragefile.c | 17 +++++++---------- >> src/util/virstoragefile.h | 7 ++----- >> 5 files changed, 9 insertions(+), 29 deletions(-) >> > > ACK, Pushed, now that 1.2.4 is out. I'm still working on further cleanups in the area as well. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list