Re: [PATCH 1/2] qemu: add host-pci-multidomain capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/30/2014 05:17 PM, Daniel P. Berrange wrote:
> On Wed, Apr 30, 2014 at 04:04:00PM +0300, Laine Stump wrote:
>> @@ -1043,6 +1044,8 @@ virQEMUCapsComputeCmdFlags(const char *help,
>>          virQEMUCapsSet(qemuCaps, QEMU_CAPS_DRIVE_SERIAL);
>>      if (strstr(help, "-pcidevice"))
>>          virQEMUCapsSet(qemuCaps, QEMU_CAPS_PCIDEVICE);
>> +    if (strstr(help, "[seg:]bus"))
>> +        virQEMUCapsSet(qemuCaps, QEMU_CAPS_HOST_PCI_MULTIDOMAIN);
> I'd suggest tightening that up a little to at least 'host=[seg:]bus'

Okay, I've done that locally (I was undecided about where to draw the
line when I wrote the patch. It seems a bit odd to be checking the
-pcidevice help for clues on the format of -device pci-assign anyway....)

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]