On 04/29/2014 02:36 AM, Michal Privoznik wrote: > Currently, there's an issue with virStrToLong_* APIs that they turn > "-1" into UINT_MAX. While this is not acceptable, it works on 64 bit > architectures and doesn't work on 32 bit ones. I know that much > cleaner solution is required, but given that we are in the freeze we > may as well just skip the test on 32 bits. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > tests/virstoragetest.c | 54 ++++++++++++++++++++++++++++++++------------------ > 1 file changed, 35 insertions(+), 19 deletions(-) NACK - this is papering over the problem. The point of freeze is to fix the root cause of the problem, not paper over it. I'll look into this today, and propose an alternative. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list