On Sun, 2014-03-30 at 21:03 +0200, Matthias Bolte wrote: > I had the code in these two patches bascially sitting around since 2012, > yes 2012! But I never managed to get the code properly split into patches > and touched up good enough to post it here. This was also hindered by the > fact that I had no ESX test system at hand for the last year or so. > > Dawid Zamirski posted some patches [1] to implement virDomainScreenshot > for ESX. So I finally managed to set up some ESX test system again this > weekend and get my old code dusted up. His implementation has two > disadvantages, namely storing the screenshot to a temporary file before > feeding it to a stream and the method of creating the screenshot itself > is availalbe since ESX 4.0 only. > > My implementation direcly feeds the screenshot data to a stream and > screenshot creation uses a method available since ESX 2.5. > > [1] https://www.redhat.com/archives/libvir-list/2014-March/msg01786.html > > -- > libvir-list mailing list > libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list Hi Matthias, Is there any chance that those patches will be merged in time for 1.2.4 which is entering code freeze soon? [1] As for the patches I posted earlier, namely enabling VI API > 2.5 [2], personally I don't need them anymore since you posted a better solution that does not need it, but if you still think that they are worth merging I can update it as per your feedback. [1] https://www.redhat.com/archives/libvir-list/2014-April/msg01000.html [2] https://www.redhat.com/archives/libvir-list/2014-March/msg01787.html Thanks, Dawid -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list