Re: [PATCH] build: avoid 'index' as variable name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 24, 2014 at 03:43:31PM -0600, Eric Blake wrote:
> Once again, gcc 4.4.7 (hello RHEL) rears its ugly head:
> 
> conf/domain_conf.c: In function 'virDomainDiskBackingStoreFormat':
> conf/domain_conf.c:14940: error: declaration of 'index' shadows a global declaration [-Wshadow]
> /usr/include/string.h:489: error: shadowed declaration is here [-Wshadow]
> 
> * src/conf/domain_conf.c (virDomainDiskBackingStoreFormat): Pacify
> older gcc.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
> 
> Pushing under the build-breaker rule.

Could probably do a syntax check rule to look for 'int index' to stop
us making this mistake again.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]