On 04/24/2014 04:11 PM, Eric Blake wrote: > On 04/24/2014 10:05 AM, Daniel P. Berrange wrote: >> Replace virDriverModuleInitialize with virFileFindResource >> usage. >> >> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> >> --- >> daemon/libvirtd.c | 13 +------------ >> src/driver.c | 26 +++++++------------------- >> src/driver.h | 1 - >> tests/virdrivermoduletest.c | 2 -- >> 4 files changed, 8 insertions(+), 34 deletions(-) > > ACK if you also delete the reference to virDriverModuleInitialize in > libvirt_driver_modules.syms. Hmm - that leaves libvirt_driver_modules.syms as exposing exactly one function: virDriverLoadModule. At this point, maybe it's better to just provide a stub function that gets compiled for --without-driver-modules, and just always have the entry point in libvirt_private.syms for one less symbol file to worry about. But that's a separate patch. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list