Re: [PATCHv2 4/6] Use virGetUninstalledDir() in src/storage/storage_backend_disk.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/24/2014 07:51 AM, Daniel P. Berrange wrote:
> On Tue, Mar 25, 2014 at 01:53:14PM +0530, Nehal J Wani wrote:
>> src/storage/storage_backend_disk.c:
>>    *Check if libvirtd is running uninstalled from a build tree and change
>>     parthelper_path accordingly
>>

> Hmm, it getting rather ugly & tedious to repeat this logic every
> place we need it.

I came to the same conclusion yesterday :)

> 
> I think we need another helper API really
> 
>    virFileFindBinary(const char *srcdir,
>                      const char *bindir,
>                      const char *binaryname);

Slightly different signature than my proposal - please read
https://www.redhat.com/archives/libvir-list/2014-April/msg00902.html
before doing too much duplicate work.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]