Re: [PATCHv2 2/6] Use virGetUninstalledDir() in src/util/virfile.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 25, 2014 at 01:53:12PM +0530, Nehal J Wani wrote:
> src/util/virfile.c
>    *Check if libvirtd is running uninstalled from a build tree and change
>     iohelper_path accordingly
> 
> ---
>  src/util/virfile.c |   19 +++++++++++++++++--
>  1 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/src/util/virfile.c b/src/util/virfile.c
> index fefc3fb..813ad86 100644
> --- a/src/util/virfile.c
> +++ b/src/util/virfile.c
> @@ -193,6 +193,8 @@ virFileWrapperFdNew(int *fd, const char *name, unsigned int flags)
>      bool output = false;
>      int pipefd[2] = { -1, -1 };
>      int mode = -1;
> +    char *uninstalledDir = NULL;

Should be 'const char *' since we don't own this pointer


ACK will fix when pushing

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]