On 04/17/2014 07:43 AM, Laine Stump wrote: > The check for a network being active during interface attach was being > done individually in several places (by both the lxc driver and the > qemu driver), but those places were too specific, leading to it *not* > being checked when allocating a connection/device from a macvtap or > hostdev network. > > This patch puts a single check in networkAllocateActualDevice(), which > is always called before the any network interface is attached to any > type of domain. It also removes all the other now-redundant checks > from the lxc and qemu drivers. > > [Note that prior to the previous patches in this series, it would have > been very cumbersome to apply this current patch, as macvtap and > hostdev networks would be automatically set inactive at each libvirtd > restart (unless they were marked as "autostart"). Therefore, those > patches should be seen as prerequisites to this patch for any > backporting. This comment is a placeholder that I intend to replace > with the git commit id's for those patches as soon as I have pushed > them.] > > This fixes: > > https://bugzilla.redhat.com/show_bug.cgi?id=880483 > --- > No change from V1. > > src/lxc/lxc_driver.c | 21 +++------------------ > src/lxc/lxc_process.c | 18 ++---------------- > src/network/bridge_driver.c | 10 +++++++++- > src/qemu/qemu_command.c | 18 ++---------------- > src/qemu/qemu_hotplug.c | 11 +---------- > 5 files changed, 17 insertions(+), 61 deletions(-) > ACK - still applies. John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list