On 04/22/2014 02:42 PM, Eric Blake wrote:
> On 04/20/2014 04:13 PM, Peter Krempa wrote:
>> As we already pass the whole structure down the call path there's no
>> need to return some stuff in a separate argument. Remove the argument
>> and call tweakers to avoid breaking semantics.
>
> s/call tweakers/tweak callers/
>
>>
>> virStorageFileGetMetadataFromBuf will be refactored later along with the
>> storage driver.
>> ---
>> src/util/virstoragefile.c | 13 ++++++-------
>> 1 file changed, 6 insertions(+), 7 deletions(-)
>>
>
> ACK
Oops, spoke too early: please squash this in:
diff --git i/src/util/virstoragefile.c w/src/util/virstoragefile.c
index 8a5bb01..cb22255 100644
--- i/src/util/virstoragefile.c
+++ w/src/util/virstoragefile.c
@@ -795,7 +795,7 @@ qcow2GetFeatures(virBitmapPtr *features,
* information about the file and its backing store. */
static int ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2)
ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(7)
-ATTRIBUTE_NONNULL(8) ATTRIBUTE_NONNULL(9)
+ATTRIBUTE_NONNULL(8)
virStorageFileGetMetadataInternal(const char *path,
const char *canonPath,
const char *directory,
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list