Re: qemu: Unlock the NWFilter update lock by leaving via the cleanup label

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/16/2014 11:54 PM, Stefan Berger wrote:
> Fix a locking problem by leaving the function via the cleanup label.
> 
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>
> 
> ---
>  src/qemu/qemu_driver.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK

> Index: libvirt-acl/src/qemu/qemu_driver.c
> ===================================================================
> --- libvirt-acl.orig/src/qemu/qemu_driver.c
> +++ libvirt-acl/src/qemu/qemu_driver.c
> @@ -6140,7 +6140,7 @@ qemuDomainCreateWithFlags(virDomainPtr d
>      virNWFilterReadLockFilterUpdates();
> 
>      if (!(vm = qemuDomObjFromDomain(dom)))
> -        return -1;
> +        goto cleanup;
> 
>      if (virDomainCreateWithFlagsEnsureACL(dom->conn, vm->def) < 0)
>          goto cleanup;
> 
> -- 
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]