Re: [PATCHv2 0/9] RelaxNG improvements for virStorageSource

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 14, 2014 at 16:54:11 -0600, Eric Blake wrote:
> changes since v1:
> ack'd patch pushed
> new patches 2-4 are a better rewrite of old patch 3/6
> new patches 8 and 9
> patch 9 is incomplete - I know where I want to be headed, but
> changing 400+ tests is taking a while.  I tried:
> 
> $ git grep -l '<driver.*type=' tests/*data/ | \
>   xargs sed '
>    /<driver .*type=\(\(.\)[a-zA-Z0-9]*\2\)/ h;
>    /<source /{
>      x;
>      s/<driver.*type=\(\(.\)[a-zA-Z0-9]*\2\).*>/<format type=\1>/;
>      G;
>    }'
> 
> as a way to automate the majority of the tedium, with some limited
> success (it has false positives in the lxc <filesystem> elements,
> when we really only want to affect <disk> elements>), but have not
> completed the efforts.  I'm posting the patches now, in the hopes
> that 1-8 can be approved, and 9 picked up by someone else if I'm
> unresponsive for a while (I'll be offline for much of this week due
> to the birth of my fourth child).
> 
> Eric Blake (9):
>   conf: better <disk> interleaving in schema
>   conf: move storage formats to common RNG file
>   conf: restrict external snapshots to backing store formats
>   conf: set up for per-grammar overrides in schemas
>   conf: split <disk> schema into more pieces
>   conf: move storage source details to common RNG file
>   conf: move <auth> and <encryption> to disk source
>   conf: fix omission of <driver> in domain dumpxml
>   RFC: conf: introduce <format> as synonym of <driver type=...>

I pushed the patches I ACKed (1, 2, 3, 4, 5, and 8) with the suggested
additions. I think the rest can be left for the future if needed.

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]