On 04/15/2014 03:36 PM, John Ferlan wrote: > Commit id '18642d10' caused a virt-test regression for NFS backend > storage error path checks when running the command: > > 'virsh find-storage-pool-sources-as netfs Unknown ' > > when the host did not have Gluster installed. Prior to the commit, > the test would fail with the error: > > error: internal error: Child process (/usr/sbin/showmount --no-headers > --exports Unknown) unexpected exit status 1: clnt_create: RPC: Unknown host > > After the commit, the error would be ignored, the call would succeed, > and an empty list of pool sources returned. This was tucked into the > commit message as an expected outcome. > > When the target host does not have a GLUSTER_CLI this is a regression > over the previous release. Furthermore, even if Gluster CLI was present, > but had a failure to get devices, the API would return a failure even if > the NFS backend had found devices. > > Modify the logic to return failure when the NFS backend check fails and > there's no GLUSTER_CLI or when both backend checks fail. > > If either returns success and GLUSTER_CLI is defined, then fetch and return > a list of source devices even if it's empty > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/storage/storage_backend_fs.c | 22 +++++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) ACK Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list