On Tue, Apr 15, 2014 at 10:06:22AM -0400, Stefan Berger wrote: > On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: > >+bool virNWFilterRuleIsProtocolEthernet(virNWFilterRuleDefPtr rule) > >+{ > >+ if (rule->prtclType >= VIR_NWFILTER_RULE_PROTOCOL_NONE && > >+ rule->prtclType <= VIR_NWFILTER_RULE_PROTOCOL_IPV6) > >+ return true; > >+ return false; > >+} > > I get a compilation error here. For me this code here works: > > if (/* rule->prtclType >= VIR_NWFILTER_RULE_PROTOCOL_NONE && */ > rule->prtclType <= VIR_NWFILTER_RULE_PROTOCOL_IPV6) > return true; What is the actual error you get ? That constant exists in the header files $ git grep RULE_PROTOCOL_NONE src/conf/nwfilter_conf.h src/conf/nwfilter_conf.h: VIR_NWFILTER_RULE_PROTOCOL_NONE = 0, Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list