Re: [PATCH] tests: Fix systemd test with --without-driver-modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 10, 2014 at 11:02:02 -0600, Eric Blake wrote:
> On 04/10/2014 09:26 AM, Jiri Denemark wrote:
> > Every test that makes use of virmock.h (only virsystemdtest as of now)
> > needs to be linked with -export-dynamic to make sure the LD_PRELOADed
> > mock library can access it's wrap_* symbols. Normally,
> > DRIVER_MODULE_LDFLAGS variable contains -export-dynamic but when
> > --without-driver-modules configure option is used, DRIVER_MODULE_LDFLAGS
> > is empty.
> > 
> > This patch turns on -export-dynamic for all tests unconditionally
> > regardless on --without-driver-modules. This fixes virsystemdtest and
> > all future users of virmock.h.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> > ---
> >  tests/Makefile.am | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> ACK.

Pushed, thanks.

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]