I'm almost to the point where virStorageSource can track everything that virStorageFileMetadata was used for, so that we can use one struct instead of two. But while working on this today, I noticed that virStorageFileChainLookup() does not have any unit tests, so I'll be writing those before removing the two remaining redundant fields. Eric Blake (5): conf: provide details on network backing store conf: expose probe for non-local storage conf: delete useless backingStoreIsFile field conf: return backing information separately from metadata conf: delete useless backingStoreFormat field src/conf/domain_conf.c | 2 +- src/libvirt_private.syms | 1 + src/storage/storage_backend_fs.c | 34 ++++---- src/storage/storage_backend_gluster.c | 14 ++-- src/util/virstoragefile.c | 146 +++++++++++++++++++++------------- src/util/virstoragefile.h | 9 ++- tests/virstoragetest.c | 49 ++++-------- 7 files changed, 135 insertions(+), 120 deletions(-) -- 1.9.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list