On 04/09/14 06:35, Eric Blake wrote: > Right now, we are allocating virStorageFileMetadata near the bottom > of the callchain, only after we have identified that we are visiting > a file (and not a network resource). I'm hoping to eventually > support parsing the backing chain from XML, where the backing chain > crawl then validates what was parsed rather than allocating a fresh > structure. Likewise, I'm working towards a setup where we have a > backing element even for networks. Both of these use cases are > easier to code if the allocation is hoisted earlier. > > * src/util/virstoragefile.c (virStorageFileGetMetadataInternal) > (virStorageFileGetMetadataFromFDInternal): Change signature. > (virStorageFileGetMetadataFromBuf) > (virStorageFileGetMetadataRecurse, virStorageFileGetMetadata): > Update callers. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > src/util/virstoragefile.c | 126 +++++++++++++++++++++++++++------------------- > 1 file changed, 75 insertions(+), 51 deletions(-) > ACK, Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list