Re: [PATCH 1/6] conf: track user vs. canonical name through full chain lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/09/14 06:35, Eric Blake wrote:
> The previous patch started a separation of error messages
> reported against the user-specified name, vs. tracking the
> canonical path that was actually opened.  This patch extends
> that notion, by hoisting directory detection up front, passing
> the canonical path through the entire call chain, and
> simplifying lower-level functions that can now assume that
> a canonical path and directory have been supplied.
> 
> * src/util/virstoragefile.c
> (virStorageFileGetMetadataFromFDInternal)
> (virStorageFileGetMetadataInternal): Add parameter, require
> directory.
> (virFindBackingFile): Require directory.
> (virStorageFileGetMetadataFromFD): Pass canonical path.
> (virStorageFileGetMetadataFromBuf): Likewise.
> (virStorageFileGetMetadata): Determine initial directory.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/util/virstoragefile.c | 97 ++++++++++++++++++++++++++++-------------------
>  1 file changed, 59 insertions(+), 38 deletions(-)
> 


ACK,

Peter



Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]