Re: [PATCH 1/3] tests: Don't crash when creating the config object fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 07, 2014 at 04:34:57PM -0600, Eric Blake wrote:
> On 04/07/2014 02:02 AM, Guido Günther wrote:
> > As observed when building in a chroot and QEMU_USER doesn't exist
> > ---
> >  tests/qemuargv2xmltest.c | 3 +++
> >  tests/qemuxml2argvtest.c | 3 +++
> >  2 files changed, 6 insertions(+)
> > 
> > diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c
> > index 6d7e23e..4cc3749 100644
> > --- a/tests/qemuargv2xmltest.c
> > +++ b/tests/qemuargv2xmltest.c
> > @@ -128,6 +128,9 @@ mymain(void)
> >      int ret = 0;
> >  
> >      driver.config = virQEMUDriverConfigNew(false);
> > +    if (driver.config == NULL)
> > +        return EXIT_FAILURE;
> > +
> 
> Still a failure, but at least better than a crash.
Pushed. Thanks,
 -- Guido

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]