Re: [PATCH 4/5] conf: interleave virstoragetest structs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/06/14 05:32, Eric Blake wrote:
> As I add more tests, it's getting harder to follow the split between
> a struct in one place and a test using the struct in another.
> Interleaving the tests makes changes more localized, and also makes
> debugging easier when a test goes wrong during my refactoring work.
> 
> * tests/virstoragetest.c (mymain): Modify structs as we go, rather
> than up-front.
> (testStorageChain): Make failure debugging easier.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  tests/virstoragetest.c | 331 ++++++++++++++++++++++---------------------------
>  1 file changed, 145 insertions(+), 186 deletions(-)
> 

ACK,

the original structs also were locals in mymain, thus this patch doesn't
change stack space requirements for that function.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]