If we'd come up with a struct to interpret the time, it's written in stone and there's nothing we can do about it. Even if we break up the struct into function arguments. However, we can use typed parameters and have the API extensible. For example, I'm implementing seconds granularity only for now. If later somebody feels like he/she wants to use even finer granularity, we can do that by inventing a new typed param. Same goes for timezone, etc. Michal Privoznik (4): Introduce virDomain{Get,Set}Time APIs remote: Implement remote{Get,Set}Time virsh: Expose virDomain{Get,Set}Time qemu: Implement virDomain{Get,Set}Time daemon/remote.c | 50 +++++++++++++++ include/libvirt/libvirt.h.in | 24 ++++++++ src/access/viraccessperm.c | 2 +- src/access/viraccessperm.h | 7 ++- src/driver.h | 14 +++++ src/libvirt.c | 96 +++++++++++++++++++++++++++++ src/libvirt_public.syms | 6 ++ src/qemu/qemu_agent.c | 95 ++++++++++++++++++++++++++++ src/qemu/qemu_agent.h | 6 ++ src/qemu/qemu_driver.c | 139 +++++++++++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 47 ++++++++++++++ src/remote/remote_protocol.x | 32 +++++++++- src/remote_protocol-structs | 20 ++++++ tools/virsh-domain-monitor.c | 143 +++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 16 +++++ 15 files changed, 694 insertions(+), 3 deletions(-) -- 1.9.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list