On 03/28/14 23:22, Eric Blake wrote:
> On 03/28/2014 04:01 PM, Peter Krempa wrote:
>> Use the previously implemented function to lookup glusterfs source pools
>> for the netfs pool to lookup native gluster pools too.
>> ---
>> src/storage/storage_backend_gluster.c | 50 +++++++++++++++++++++++++++++++++++
>> 1 file changed, 50 insertions(+)
>>
>
>> +
>> + if (!srcSpec) {
>> + virReportError(VIR_ERR_INVALID_ARG, "%s",
>> + _("hostname must be specified for gluster sources"));
>
> Would it make sense to check localhost if srcSpec is NULL?
Well AFAIK the netfs pool doesn't have that semantic so I didn't bother.
>
> Again, post-1.2.3, but looks reasonable. ACK
>
Pushed; Thanks
Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list