Re: [PATCH 10/n] util: don't support loopback and nbd when setuid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/29/14 21:56, Eric Blake wrote:
> The only remaining reason that virt-login-shell was trying to
> link against virstoragefile was because of a call to
> virStorageFileFormatTypeToString when spawning a qemu-nbd
> process - but setuid processes shouldn't be spawning qemu-nbd.
> 
> * src/util/virfile.c (virFileLoopDeviceAssociate)
> (virFileNBDDeviceAssociate): Cripple in setuid builds.
> * src/Makefile.am (libvirt_setuid_rpc_client_la_SOURCES):
> Drop virstoragefile from the list.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/Makefile.am    | 1 -
>  src/util/virfile.c | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

ACK

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]