On 03/28/14 23:10, Eric Blake wrote: > With this patch, all information related to a host resource in > a storage file backing chain now lives in util/virstoragefile.h. > The next step will be to consolidate various places that have > been tracking backing chain details to all use a common struct. > > The changes to tools/Makefile.am were made necessary by the > fact that virstorageencryption includes uses of libxml, and is > now pulled in by inclusion from virstoragefile.h. No > additional libraries are linked into the final image, and in > comparison, the build of the setuid library in src/Makefile.am > already was using LIBXML_CFLAGS via AM_CFLAGS. > > * src/conf/domain_conf.h (virDomainDiskSourceDef): Move... > * src/util/virstoragefile.h (virStorageSource): ...and rename. > * src/conf/domain_conf.c (virDomainDiskSourceDefClear) > (virDomainDiskAuthClear): Adjust clients. > * tools/Makefile.am (virt_login_shell_CFLAGS) > (virt_host_validate_CFLAGS): Add libxml headers. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > > Surprisingly small in size; a lot of the heavy lifting was > done piecemeal in the earlier commits. > > This one took me a while to figure out, because it took me > longer than expected to figure out the best way to resolve > the build failure of virt-login-shell and still make sure > I wasn't introducing a problem into that setuid helper. > > src/conf/domain_conf.c | 4 ++-- > src/conf/domain_conf.h | 32 ++------------------------------ > src/util/virstoragefile.h | 32 ++++++++++++++++++++++++++++++++ > tools/Makefile.am | 2 ++ > 4 files changed, 38 insertions(+), 32 deletions(-) > ACK Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list