Re: [PATCH 7/n] conf: move storage secret type to util/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/28/14 16:01, Eric Blake wrote:
> This one is a relatively easy move.  We don't ever convert the
> enum to or from strings (it is inferred from other elements in
> the xml, rather than directly represented).
> 
> * src/conf/domain_conf.h (virDomainDiskSecretType): Move...
> * src/util/virstoragefile.h (virStorageSecreteType): ...and
> rename.
> * src/conf/domain_conf.c (virDomainDiskSecretType): Drop unused
> enum conversion.
> (virDomainDiskAuthClear, virDomainDiskDefParseXML)
> (virDomainDiskDefFormat): Adjust clients.
> * src/qemu/qemu_command.c (qemuGetSecretString): Likewise.
> * src/qemu/qemu_conf.c (qemuTranslateDiskSourcePoolAuth):
> Likewise.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c    | 19 +++++++------------
>  src/conf/domain_conf.h    | 10 +---------
>  src/qemu/qemu_command.c   |  8 ++++----
>  src/qemu/qemu_conf.c      |  8 ++++----
>  src/util/virstoragefile.h |  9 +++++++++
>  5 files changed, 25 insertions(+), 29 deletions(-)
> 

ACK

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]