On Fri, Mar 28, 2014 at 08:11:20AM -0600, Mike Latimer wrote: > On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote: > > On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: > > > Move the test for /usr/sbin/lldptool up so libvirt-tck will report the > > > skip > > > and reason, rather than passing the test as 'ok'. > > > > So we're talking about the difference between the test > > indicating "OK 3 out of 3 tests skipped" vs "SKIPPED" ? > > If so, that sounds like a nice improvement > > Yes, but the real reason for the change is when you are running the full > libvirt-tck suite. This patch changes the following output: > > .../230-no-mac-broadcast.t .............. ok > .../240-no-arp-spoofing.t ............... ok > .../300-vsitype.t ....................... ok > .../100-disk-encryption.t ................... ok > .../200-qcow2-single-backing-file.t ......... ok > > To this: > > .../230-no-mac-broadcast.t .............. ok > .../240-no-arp-spoofing.t ............... ok > .../300-vsitype.t ....................... skipped: lldptool is not available > .../100-disk-encryption.t ................... ok > .../200-qcow2-single-backing-file.t ......... ok Yep. that makes sense. Will push this, and rebase mine change on top of it. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list