On Thu, Mar 27, 2014 at 06:04:41AM -0600, Eric Blake wrote: > On 03/27/2014 05:44 AM, Daniel P. Berrange wrote: > > You might want to 'git config format.subjectprefix "tck PATCH"' to make > it obvious when you are patching libvirt-tck. > > > A number of the nwfilter XML files have attribute values > > which are out of range. Previously the libvirt nwfilter > > XML parser would silently ignore illegal values, causing > > them to default to 0. This resulted in creating incorrect > > iptables rules, which the TCK suite then validated as > > correct. Current libvirt returns a hard error for illegal > > XML values. To address this we either change the attribute > > values to be valid, or delete the bogus rules entirely if > > they are duplicates of other existing valid rules. > > > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > > --- > > scripts/nwfilter/nwfilterxml2fwallout/arp-test.fwall | 1 - > > ACK. Are you also planning on pushing Mike's patches that you have acked? Yes, I pushed the one I acked Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list