On 03/27/2014 05:44 AM, Daniel P. Berrange wrote: > Newer ebtables tools turn 0x8035 into RARP, so our test > file must expect this. > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > --- > scripts/nwfilter/nwfilterxml2fwallout/testvm.fwall.dat | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) ACK > -#ebtables -t nat -L libvirt-I-vnet0 | grep -v "^Bridge" | grep -v "^$" > +#ebtables -t nat -L libvirt-I-vnet0 | sed s/0x8035/RARP/g | grep -v "^Bridge" | grep -v "^$" You know, sed|grep|grep is overkill, when you could do it all in sed: ebtables -t nat -L libvirt-I-vnet0 | \ sed 's/0x8035/RARP/g; /^Bridge/d; /^$/d' But I don't care about the minor efficiency gain enough to demand the change. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list