Re: [PATCH 0/5] virCommandRunRegex cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/26/2014 02:20 PM, Michal Privoznik wrote:
> On 25.03.2014 08:17, Ján Tomko wrote:
>> Simplify the code. This should have no functional change
>> (except for the impossible leak fix in 3/5). Most of this
>> functionality is tested in viriscsitest.
>>
>> Ján Tomko (5):
>>    Remove useless 'maxReg' variable
>>    Simplify the loop in virCommandRunRegex
>>    Free groups in case of a partial match
>>    Use VIR_STRNDUP instead of modifying the matched string
>>    Shift the for loop over matched vars by one
>>
>>   src/util/vircommand.c | 46 +++++++++++++++++++---------------------------
>>   1 file changed, 19 insertions(+), 27 deletions(-)
>>
> 
> ACK series.
> 

Thanks; pushed now.

Jan


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]