Re: [PATCH 18/18] conf: prepare to track multiple host source files per <disk>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/19/2014 11:20 AM, Eric Blake wrote:
> It's finally time to start tracking disk backing chains in
> <domain> XML.  The first step is to start refactoring code
> so that we have an object more convenient for representing
> each host source resource in the context of a single guest
> <disk>.  Ultimately, I plan to move the new type into src/util
> where it can be reused by virStorageFile, but to make the
> transition easier to review, this patch just creates the
> new type then fixes everything until it compiles again.

Okay, ACK to this too. It appears to be completely mechanical changes,
so the compiler is just as good a reviewer as I am (I examined to see if
there was anything that looked like more than using a different name for
something (didn't see anything), and compiled successfully.

So the entire series is fine except the leaks in 15/18.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]