Re: [PATCH 14/18] conf: use disk source accessors in vmware/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/21/2014 03:01 PM, Laine Stump wrote:
> On 03/19/2014 11:20 AM, Eric Blake wrote:
>> Part of a series of cleanups to use new accessor methods.
>>
>> While writing this, I also discovered that conversion from XML
>> to vmware modified the disk source in place; if the same code
>> is reached twice, the second call behaves differently because
>> the first call didn't clean up its mess.
>>
> 
> So this fixes the bug you mentioned in the log message. Might be better
> if it was a different patch. (No need to resend though) (BTW, you
> haven't seen any ACKs yet because I'm going to give one for the whole
> series to reduce clutter :-)

Okay, I can split this patch into two parts when pushing; bug fix first,
then accessors second.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]