Re: More java bindings functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



That seems a little complicated...sorry but I never used git in this way and I have very little time to learn this too.

They are just 3-4 source files, if someone can handle this for me I'd be happy to send them so they can upload in the right way.
Sources are less then 150Kb, that is for sure...if I send you a .rar with the sources would it be ok?


2014-03-17 13:43 GMT+01:00 Eric Blake <eblake@xxxxxxxxxx>:
On 03/17/2014 01:46 AM, Claudio Bley wrote:
> At Sun, 16 Mar 2014 20:07:48 +0100,
> Pasquale Dir wrote:
>>
>> I just added, because I needed them, two new bindings for java apis:
>>
>> Connection.getCpuStats(int, long)
>> and
>> Domain.getCpuStats(int, long)
>
> What do those parameters mean? What's the return type of these methods?
>
>> these two functions act like python's counterpart.
>>
>> I give you the .jar with sources
>
> If there was an attachment, it has been stripped by the mailing list
> processor.

The mailing list DID strip it.  Your .jar was bigger than the mail limit
of 150k.  That, and binary attachments are frowned on - we prefer
dealing with source patches, not binaries.

>
> Please send your patches directly to the list as that eases review a
> lot. In order to do so, just use the "git send-email" command. See
> http://libvirt.org/hacking.html#patches for general tips.
>
> Also, you might want to use
> "git config format.subjectprefix 'java][PATCH'" in order to indicate
> the project you're working on in the subject.

Both pieces of good advice.

--
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]