[PATCH v3 2/5] remote: Implement virDomainFSFreeze and virDomainFSThaw

[Tomoki Sekiyama <tomoki.sekiyama@xxxxxxx>]

New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze',
which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.

Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxx>
---
 src/access/viraccessperm.c   |    2 +-
 src/access/viraccessperm.h   |    6 ++++++
 src/remote/remote_driver.c   |    2 ++
 src/remote/remote_protocol.x |   25 +++++++++++++++++++++++--
 src/remote_protocol-structs  |    9 +++++++++
 src/rpc/gendispatch.pl       |    2 ++
 6 files changed, 43 insertions(+), 3 deletions(-)

diff --git a/src/access/viraccessperm.c b/src/access/viraccessperm.c
index d517c66..462f46c 100644
--- a/src/access/viraccessperm.c
+++ b/src/access/viraccessperm.c
@@ -39,7 +39,7 @@ VIR_ENUM_IMPL(virAccessPermDomain,
               "start", "stop", "reset",
               "save", "delete",
               "migrate", "snapshot", "suspend", "hibernate", "core_dump", "pm_control",
-              "init_control", "inject_nmi", "send_input", "send_signal", "fs_trim",
+              "init_control", "inject_nmi", "send_input", "send_signal", "fs_trim", "fs_freeze",
               "block_read", "block_write", "mem_read",
               "open_graphics", "open_device", "screenshot",
               "open_namespace");
diff --git a/src/access/viraccessperm.h b/src/access/viraccessperm.h
index 6d14f05..ac48d70 100644
--- a/src/access/viraccessperm.h
+++ b/src/access/viraccessperm.h
@@ -242,6 +242,12 @@ typedef enum {
      */
     VIR_ACCESS_PERM_DOMAIN_FS_TRIM,      /* Issue TRIM to guest filesystems */
 
+    /**
+     * @desc: Freeze and thaw domain filesystems
+     * @message: Freezing and thawing domain filesystems require authorization
+     */
+    VIR_ACCESS_PERM_DOMAIN_FS_FREEZE,    /* Freeze and thaw guest filesystems */
+
     /* Peeking at guest */
 
     /**
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 92aff63..996a006 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -7662,6 +7662,8 @@ static virDriver remote_driver = {
     .domainMigrateFinish3Params = remoteDomainMigrateFinish3Params, /* 1.1.0 */
     .domainMigrateConfirm3Params = remoteDomainMigrateConfirm3Params, /* 1.1.0 */
     .connectGetCPUModelNames = remoteConnectGetCPUModelNames, /* 1.1.3 */
+    .domainFSFreeze = remoteDomainFSFreeze, /* 1.2.3 */
+    .domainFSThaw = remoteDomainFSThaw, /* 1.2.3 */
 };
 
 static virNetworkDriver network_driver = {
diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
index f1f2359..e8904a5 100644
--- a/src/remote/remote_protocol.x
+++ b/src/remote/remote_protocol.x
@@ -2952,6 +2952,15 @@ struct remote_network_event_lifecycle_msg {
     int detail;
 };
 
+struct remote_domain_fsfreeze_args {
+    remote_nonnull_domain dom;
+    unsigned int flags;
+};
+
+struct remote_domain_fsthaw_args {
+    remote_nonnull_domain dom;
+    unsigned int flags;
+};
 
 
 /*----- Protocol. -----*/
@@ -4282,7 +4291,7 @@ enum remote_procedure {
     /**
      * @generate: both
      * @acl: domain:snapshot
-     * @acl: domain:write:VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
+     * @acl: domain:fs_freeze:VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
      */
     REMOTE_PROC_DOMAIN_SNAPSHOT_CREATE_XML = 185,
 
@@ -5262,5 +5271,17 @@ enum remote_procedure {
      * @generate: both
      * @acl: none
      */
-    REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333
+    REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333,
+
+    /**
+     * @generate: both
+     * @acl: domain:fs_freeze
+     */
+    REMOTE_PROC_DOMAIN_FSFREEZE = 334,
+
+    /**
+     * @generate: both
+     * @acl: domain:fs_freeze
+     */
+    REMOTE_PROC_DOMAIN_FSTHAW = 335
 };
diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
index 5636d55..07086a0 100644
--- a/src/remote_protocol-structs
+++ b/src/remote_protocol-structs
@@ -2420,6 +2420,13 @@ struct remote_network_event_lifecycle_msg {
         remote_nonnull_network     net;
         int                        event;
         int                        detail;
+struct remote_domain_fsfreeze_args {
+        remote_nonnull_domain      dom;
+        u_int                      flags;
+};
+struct remote_domain_fsthaw_args {
+        remote_nonnull_domain      dom;
+        u_int                      flags;
 };
 enum remote_procedure {
         REMOTE_PROC_CONNECT_OPEN = 1,
@@ -2755,4 +2762,6 @@ enum remote_procedure {
         REMOTE_PROC_DOMAIN_EVENT_CALLBACK_BALLOON_CHANGE = 331,
         REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMSUSPEND_DISK = 332,
         REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333,
+        REMOTE_PROC_DOMAIN_FSFREEZE = 334,
+        REMOTE_PROC_DOMAIN_FSTHAW = 335,
 };
diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
index ceb1ad8..0b256f3 100755
--- a/src/rpc/gendispatch.pl
+++ b/src/rpc/gendispatch.pl
@@ -64,6 +64,8 @@ sub fixup_name {
     $name =~ s/Nmi$/NMI/;
     $name =~ s/Pm/PM/;
     $name =~ s/Fstrim$/FSTrim/;
+    $name =~ s/Fsfreeze$/FSFreeze/;
+    $name =~ s/Fsthaw$/FSThaw/;
     $name =~ s/Scsi/SCSI/;
     $name =~ s/Wwn$/WWN/;
 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list