Roman Bogorodskiy wrote: > Add testing for xml -> args generation. It's largely based on the > similar test for qemu. As it's my first experience with unit testing > in libvirt and in unit testing in C in general, I'm not sure I haven't > miss some important pieces, but it works as expected for me. > > I'm also not sure about the license headers: some tests have them, > some don't, so I decided not to add them for now. One more note on that. Original reason for the test was hostbridge device handling which happened in the network handling piece by mistake. This test doesn't test that because currently bhyve driver does NOT allow to create domains without networks. The reason for that is that currently networking is the only way to communicate with the guest and it makes no sense to start domain without network. However, I think it's a good base for future test and I plan to change this behaviour once I manage to bring in the nmdm/console support for bhyve. Roman Bogorodskiy
Attachment:
pgpN_lej5W6nv.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list