Re: [PATCH] Fix virQEMUCapsLoadCache leaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/19/2014 06:33 PM, Martin Kletzander wrote:
> On Wed, Mar 19, 2014 at 05:17:40PM +0100, Ján Tomko wrote:
>> Valgrind reported leaking of maxCpus and arch strings from
>> virXPathString, as well as the leak of the machineMaxCpus array.
>>
>> Use 'tmp' for the strings we don't want to free, to allow freeing
>> of 'str' in the cleanup label and free machineMaxCpus
>> in virCapsReset too.
>> ---
>>  src/qemu/qemu_capabilities.c | 18 +++++++++++-------
>>  1 file changed, 11 insertions(+), 7 deletions(-)
>>

> 
> ACK with the suggestions being optional to squash in.
> 

I've removed the 'tmp' variable and pushed it, thank you for the review.

Jan


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]