v1: https://www.redhat.com/archives/libvir-list/2014-March/msg00720.html v2: * instead of using cat, switch RunProgRegex to use a synchronous command and modify the output buffer via a virCommandDryRun callback * move the functions dealing with iscsiadm out of the iscsi backend to src/util (and move StorageBackendRunRegex as well) Ján Tomko (8): Sort includes in storage_backend_iscsi.c Move virStorageBackendRun to vircommand Switch virCommandRunRegex to use virStringSplit Don't create iscsiadm command line in ISCSIPool{Start,Stop} Remove storage pool from the arguments of a few functions Move functions using iscsiadm to viriscsi.c Add test for virISCSIGetSession Add test for virISCSIScanTargets po/POTFILES.in | 1 + src/Makefile.am | 1 + src/libvirt_private.syms | 11 + src/storage/storage_backend.c | 249 ----------------- src/storage/storage_backend.h | 22 -- src/storage/storage_backend_disk.c | 43 +-- src/storage/storage_backend_fs.c | 9 +- src/storage/storage_backend_iscsi.c | 482 ++------------------------------ src/storage/storage_backend_iscsi.h | 4 - src/storage/storage_backend_logical.c | 63 +++-- src/util/vircommand.c | 242 +++++++++++++++++ src/util/vircommand.h | 20 ++ src/util/viriscsi.c | 498 ++++++++++++++++++++++++++++++++++ src/util/viriscsi.h | 52 ++++ tests/Makefile.am | 6 + tests/viriscsitest.c | 219 +++++++++++++++ 16 files changed, 1145 insertions(+), 777 deletions(-) create mode 100644 src/util/viriscsi.c create mode 100644 src/util/viriscsi.h create mode 100644 tests/viriscsitest.c -- 1.8.3.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list