On 03/18/2014 09:47 AM, Daniel P. Berrange wrote: > On Tue, Mar 18, 2014 at 09:21:14AM -0600, Eric Blake wrote: >> On 03/18/2014 07:36 AM, Daniel P. Berrange wrote: >>> The 'int isTempChain' parameter to various nwfilter methods >>> only takes two values so should be a bool type. >>> >>> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> >>> --- >>> src/nwfilter/nwfilter_ebiptables_driver.c | 24 ++++++++++++------------ >>> 1 file changed, 12 insertions(+), 12 deletions(-) >>> >> >> This touches a lot of the same lines as 1/6 when you changed incoming to >> bool. Should you squash the two patches to minimize the churn? > > I just found it easier to review the change when it was only doing > one variable at a time, so I think its nicer to keep them separate And after reading patch 3/6, I also see where doing one thing at a time helps because that patch changed the number of parameters. Okay, I agree: no squashing necessary. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list