On Tue, Mar 18, 2014 at 09:26:09AM +0100, Michal Privoznik wrote: > The @ret value is built in a loop. However, if in one iteration > there's an error, we should free all the fields built so far. For > instance, if there's an error and the previous item was > type of VIR_TYPED_PARAM_STRING we definitely must free it. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > libvirt-override.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK, Martin > diff --git a/libvirt-override.c b/libvirt-override.c > index 3765a43..7f746ed 100644 > --- a/libvirt-override.c > +++ b/libvirt-override.c > @@ -259,7 +259,7 @@ setPyVirTypedParameter(PyObject *info, > return ret; > > cleanup: > - VIR_FREE(ret); > + virTypedParamsFree(ret, size); > return NULL; > } > > -- > 1.9.0 > > -- > libvir-list mailing list > libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list