Re: [PATCH] bhyve: allow to destroy only active domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Daniel P. Berrange wrote:

> On Sat, Mar 15, 2014 at 07:49:14PM +0400, Roman Bogorodskiy wrote:
> > Add a check that domain is active before attempting to destroy it.
> > ---
> >  src/bhyve/bhyve_driver.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
> > index 9dbb299..60d49de 100644
> > --- a/src/bhyve/bhyve_driver.c
> > +++ b/src/bhyve/bhyve_driver.c
> > @@ -567,6 +567,12 @@ bhyveDomainDestroy(virDomainPtr dom)
> >      if (virDomainDestroyEnsureACL(dom->conn, vm->def) < 0)
> >          goto cleanup;
> >  
> > +    if (!virDomainObjIsActive(vm)) {
> > +        virReportError(VIR_ERR_OPERATION_INVALID,
> > +                       "%s", _("Domain is not running"));
> > +        goto cleanup;
> > +    }
> > +
> >      ret = virBhyveProcessStop(privconn, vm, VIR_DOMAIN_SHUTOFF_DESTROYED);
> 
> ACK

Pushed, thanks!

Roman Bogorodskiy

Attachment: pgpaBD6_AVKUC.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]