Re: [PATCH] virlog: add log lock in virLogSetDefaultPriority

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 17, 2014 at 01:59:06PM +0100, Michal Privoznik wrote:
> On 17.03.2014 13:30, Wangrui (K) wrote:
> >When the global variable virLogDefaultPriority is modified, it will
> >
> >be better to have a lock.
> >
> >Signed-off-by: Zhou Yimin <zhouyimin@xxxxxxxxxx>
> >
> >---
> 
> Is there any specific behavior you are seeing? There's nothing wrong
> with the patch, but as far as I know Dan is trying to kill the log
> lock.

Adding this particular lock is ok. The situation should be harmless
though, since this function is only called in single-threaded
contexts I believe.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]