Re: [PATCH] add flag to enforce hugepage backing of guest RAM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 14, 2014 at 06:52:19PM -0300, Marcelo Tosatti wrote:
> On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote:
> > On Tue, Feb 04, 2014 at 04:42:02PM +0000, Daniel P. Berrange wrote:
> > > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote:
> > > > 
> > > > Add an element named "strict-hugepages" to control whether to 
> > > > refuse guest initialization in case hugepage allocation cannot 
> > > > be performed.
> > > > 
> > > > Signed-off-by: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
> > > > 
> > > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> > > > index ff50214..e79f5e6 100644
> > > > --- a/docs/formatdomain.html.in
> > > > +++ b/docs/formatdomain.html.in
> > > > @@ -632,6 +632,9 @@
> > > >        <dt><code>hugepages</code></dt>
> > > >        <dd>This tells the hypervisor that the guest should have its memory
> > > >          allocated using hugepages instead of the normal native page size.</dd>
> > > > +      <dt><code>strict-hugepages</code></dt>
> > > > +      <dd>This tells the hypervisor that the guest should refuse to start
> > > > +          in case of failure to allocate guest memory with hugepages</dd>
> > > 
> > > Huh, we already supply the -mem-prealloc command line flag alongside
> > > the -mem-path flag which should cause QEMU to exit if it cannot allocate
> > > all memory upfront.
> 
> Daniel,
> 
> Can we merge this patch please? 
> 
> Paolo thinks it belongs to libvirt.

We recently had a bunch more feature requests around huge page support
in libvirt, so I think it is preferrable not to merge this currently.
We need to examine the broader problem to come up with a coherant
design for the whole problemspace.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]