Re: [PATCH] Introduce virFDStreamOpenPTY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Roman Bogorodskiy wrote:

> Add virFDStreamOpenPTY() function which is a wrapper around
> virFDStreamOpenFileInternal() with putting the device it opens into a
> raw mode.
> 
> Make virChrdevOpen() use virFDStreamOpenPTY() for
> VIR_DOMAIN_CHR_TYPE_PTY devices.
> 
> This fixes mangled console output when libvirt runs on FreeBSD as it
> requires device it opens to be placed into a raw mode explicitly.
> ---
>  src/conf/virchrdev.c |  2 +-
>  src/fdstream.c       | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/fdstream.h       |  5 +++++
>  3 files changed, 59 insertions(+), 1 deletion(-)

And I've just realised there's one more change that needs to be squashed
in for this:

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index aaaac2f..7b181b5 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -797,6 +797,7 @@ virFDStreamConnectUNIX;
 virFDStreamCreateFile;
 virFDStreamOpen;
 virFDStreamOpenFile;
+virFDStreamOpenPTY;
 virFDStreamSetIOHelper;
 
Roman Bogorodskiy

Attachment: pgpiYMtcJyGX2.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]