Re: [PATCH 6/6] build: detect/prohibit hardcoded XML indent in syntax-check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/12/2014 10:04 PM, Laine Stump wrote:
> This rule wouldn't be able to find any case of a hardcoded indent that
> was in the middle of a string, but then virBuffer doesn't add
> indentation in the middle of a string either.
> ---
>  cfg.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

ACK (but I'm biased, as I helped write it)

>  
> +sc_forbid_manual_xml_indent:
> +	@prohibit='virBuffer.*" +<'			\
> +	halt='use virBufferAdjustIndent instead of spaces when indenting xml'	\

Maybe line up the \ to a common column?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]