On Thu, Mar 13, 2014 at 04:45:35PM +0530, Nehal J Wani wrote:
> >> +/**
> >> + * VIR_NETWORK_DHCP_LEASE_FILE_SIZE_MAX:
> >> + *
> >> + * Macro providing the upper limit on the size of leases file
> >> + */
> >> +#define VIR_NETWORK_DHCP_LEASE_FILE_SIZE_MAX (2 * 1024 * 1024)
> >
> > Do you think this is large enough ? Lets imagine a case of
> > 65,000 leases - will they all fit in 2 MB given the JSON
> > formatting we're doing ?
>
> The following JSON formatted lease takes 274 bytes:
> {
> "iaid": "1221229",
> "ip-address": "2001:db8:ca2:2:1::95",
> "mac-address": "52:54:00:12:a2:6d",
> "hostname": "Fedora20",
> "client-id": "00:04:1a:c1:d9:6b:5a:0a:e2:bc:f8:4b:1e:37:2e:38:22:55",
> "expiry-time": 1393244216
> },
>
> So, assuming an upper limit of 512 bytes for each such entry, is it
> safe to change the above limit to 32 MB?
Yep, if they're running so many VMs on a host, then they must have a
lot of RAM so 32mb will be tiny by comparison.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list