On Wed, Mar 05, 2014 at 02:53:03PM -0500, Tomoki Sekiyama wrote:
> New rules are added in fixup_name in gendispatch.pl to keep the name
> FSFreeze and FSThaw.
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxx>
> ---
> src/remote/remote_driver.c | 2 ++
> src/remote/remote_protocol.x | 23 ++++++++++++++++++++++-
> src/remote_protocol-structs | 9 +++++++++
> src/rpc/gendispatch.pl | 2 ++
> 4 files changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 955465a..8a4efe4 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -7660,6 +7660,8 @@ static virDriver remote_driver = {
> .domainMigrateFinish3Params = remoteDomainMigrateFinish3Params, /* 1.1.0 */
> .domainMigrateConfirm3Params = remoteDomainMigrateConfirm3Params, /* 1.1.0 */
> .connectGetCPUModelNames = remoteConnectGetCPUModelNames, /* 1.1.3 */
> + .domainFSFreeze = remoteDomainFSFreeze, /* 1.2.3 */
> + .domainFSThaw = remoteDomainFSThaw, /* 1.2.3 */
> };
>
> static virNetworkDriver network_driver = {
> @@ -5262,5 +5271,17 @@ enum remote_procedure {
> * @generate: both
> * @acl: none
> */
> - REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333
> + REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333,
> +
> + /**
> + * @generate: both
> + * @acl: domain:write
> + */
> + REMOTE_PROC_DOMAIN_FSFREEZE = 334,
> +
> + /**
> + * @generate: both
> + * @acl: domain:write
> + */
> + REMOTE_PROC_DOMAIN_FSTHAW = 335
I think this is a case where we should invent a new permission name.
Add VIR_ACCESS_PERM_DOMAIN_FS_FREEZE to src/access/viraccessperm.h
and use it for both of these RPC calls. We should also make the
existing VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag for snapshot APIs
uses this new permission.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list