On Thu, Mar 13, 2014 at 09:22:30AM +0000, qiaonuohan@xxxxxxxxxxxxxx wrote:
> On 03/13/2014 03:40 PM, Martin Kletzander wrote:
> > On Wed, Mar 12, 2014 at 05:18:22PM +0000, Daniel P. Berrange wrote:
> >> > On Thu, Mar 06, 2014 at 09:35:47AM +0000,qiaonuohan@xxxxxxxxxxxxxx wrote:
> >>> > > This patch is used to add "--compress" and "[--compression-format]<string>" to
> >>> > > "virsh dump --memory-only". And "virsh dump --memory-only" is going be
> >>> > > implemented by new virDomainCoreDumpWithFormat API.
> >>> > >
> >>> > > Signed-off-by: Qiao Nuohan<qiaonuohan@xxxxxxxxxxxxxx>
> >>> > > ---
> >>> > > tools/virsh-domain.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
> >>> > > 1 file changed, 44 insertions(+), 1 deletion(-)
> >>> > >
> >>> > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> >>> > > index 2e3f0ed..70613e5 100644
> >>> > > --- a/tools/virsh-domain.c
> >>> > > +++ b/tools/virsh-domain.c
> >>> > > @@ -4486,6 +4486,14 @@ static const vshCmdOptDef opts_dump[] = {
> >>> > > .type = VSH_OT_BOOL,
> >>> > > .help = N_("dump domain's memory only")
> >>> > > },
> >>> > > + {.name = "compress",
> >>> > > + .type = VSH_OT_BOOL,
> >>> > > + .help = N_("make qemu dump domain's memory in kdump-compressed format")
> >>> > > + },
> >>> > > + {.name = "compression-format",
> >>> > > + .type = VSH_OT_DATA,
> >>> > > + .help = N_("specify the compression format of kdump-compressed format")
> >>> > > + },
> >> >
> >> > As before, IMHO having two args here is silly. Just have a
> >> > single '--compress format' arg.
> >> >
> > I'm fine with having one param only, I don't know about the author,
> > though. I also proposed '--compress' as an alias which should be good
> > compromise IMHO.
> >
>
> I would prefer Martin's suggestion, for zlib is used more frequently, an alias
> can save typing.
>
Although one might suggest an alias or a wrapper if you want to save
typing...
Martin
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list